fix: force VerifyServerDataDir fallback over TCP#3485
Closed
Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Closed
fix: force VerifyServerDataDir fallback over TCP#3485Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dolt sqlhelper for verification pathsVerifyServerDataDir's fallbackSHOW DATABASESquery to that helperDOLT_CLI_PASSWORDonly for remote fallback checks when config omits a passwordWhy
Builds on the explicit-TCP helper work in #3470 and the daemon-helper parity follow-up in #3482.
VerifyServerDataDirstill had one fallback path that could issueSHOW DATABASESthrough the older localdolt sqlbehavior. That left imposter detection able to drift back into embedded-mode / autodiscovery behavior instead of querying the live shared server.This PR keeps that remaining fallback path on the same explicit TCP client path without broadening into unrelated Dolt shellout cleanup.
Validation
GOTOOLCHAIN=auto go test ./internal/doltserver -run 'TestBuildDoltSQLTCPClientCmd_(Local|Remote|RemoteNoPasswordPreservesInheritedCredentials)$|TestBuildDoltSQLCmd.*|TestCheckServerReachable.*|TestIsRunning.*'Notes
internal/doltserververification fallback behavior and focused tests.